Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add better mandatory cluster rules in matterlint #19165

Merged
merged 2 commits into from
Jun 3, 2022
Merged

Add better mandatory cluster rules in matterlint #19165

merged 2 commits into from
Jun 3, 2022

Conversation

andy31415
Copy link
Contributor

Problem

Update mandatory clusters for endpoint 0 (which should always be a root node) based on the spec:

  • added a few mandatory clusters
  • removed OTA requirement (I do not see it as mandatory in the spec)

Testing

./scripts/lint_idl.py still runs and outputs results (it parses, saw lint errors on various scripts)

@boring-cyborg boring-cyborg bot added the scripts label Jun 3, 2022
@github-actions
Copy link

github-actions bot commented Jun 3, 2022 •
edited
Loading

PR #19165: Size comparison from 63eec80 to c24fe95

Full report (12 builds for cyw30739, k32w, linux, mbed, nrfconnect, telink)
platform target config section 63eec80 c24fe95 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 602078 602078 0 0.0
.app_xip_area 461104 461104 0 0.0
.bss 83912 83912 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 598178 598178 0 0.0
.app_xip_area 457076 457076 0 0.0
.bss 84072 84072 0 0.0
.data 712 712 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 596842 596842 0 0.0
.app_xip_area 456864 456864 0 0.0
.bss 83044 83044 0 0.0
.data 620 620 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
k32w light k32w061+release (read/write) 657944 657944 0 0.0
.bss 69760 69760 0 0.0
.data 2016 2016 0 0.0
.text 580368 580368 0 0.0
lock k32w061+release (read/write) 716960 716960 0 0.0
.bss 70184 70184 0 0.0
.data 1984 1984 0 0.0
.text 638992 638992 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9358940 9358940 0 0.0
(read/write) 662865 662865 0 0.0
.bss 42257 42257 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 600808 600808 0 0.0
.dynamic 528 528 0 0.0
.got 14816 14816 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 459452 459452 0 0.0
.text 7385348 7385348 0 0.0
thermostat-no-ble arm64 (read only) 2367420 2367420 0 0.0
(read/write) 177505 177505 0 0.0
.bss 87921 87921 0 0.0
.data 1528 1528 0 0.0
.data.rel.ro 80264 80264 0 0.0
.dynamic 528 528 0 0.0
.got 4792 4792 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 148828 148828 0 0.0
.text 1988896 1988896 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2425752 2425752 0 0.0
.bss 202620 202620 0 0.0
.data 5872 5872 0 0.0
.text 1388396 1388396 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1188179 1188179 0 0.0
bss 141277 141277 0 0.0
rodata 153036 153036 0 0.0
text 814984 814984 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1136943 1136943 0 0.0
bss 140506 140506 0 0.0
rodata 129600 129600 0 0.0
text 788024 788024 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 780852 780852 0 0.0
bss 70564 70564 0 0.0
noinit 40416 40416 0 0.0
text 552246 552246 0 0.0
lighting-app tlsr9518adk80d (read/write) 800888 800888 0 0.0
bss 70824 70824 0 0.0
noinit 40416 40416 0 0.0
text 568988 568988 0 0.0

@github-actions
Copy link

github-actions bot commented Jun 3, 2022 •
edited
Loading

PR #19165: Size comparison from 63eec80 to 669f36c

Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 63eec80 669f36c change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 648675 648675 0 0.0
(read/write) 158900 158900 0 0.0
.bss 74580 74580 0 0.0
.data 3404 3404 0 0.0
.rodata 84531 84531 0 0.0
.text 563908 563908 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 615555 615555 0 0.0
(read/write) 158072 158072 0 0.0
.bss 73812 73812 0 0.0
.data 3344 3344 0 0.0
.rodata 73915 73915 0 0.0
.text 541404 541404 0 0.0
lock-ftd LP_CC2652R7 (read only) 680751 680751 0 0.0
(read/write) 162072 162072 0 0.0
.bss 72604 72604 0 0.0
.data 3268 3268 0 0.0
.rodata 96687 96687 0 0.0
.text 583580 583580 0 0.0
lock-mtd LP_CC2652R7 (read only) 630151 630151 0 0.0
(read/write) 145724 145724 0 0.0
.bss 68340 68340 0 0.0
.data 3268 3268 0 0.0
.rodata 96567 96567 0 0.0
.text 533092 533092 0 0.0
pump-app LP_CC2652R7 (read only) 664039 664039 0 0.0
(read/write) 179696 179696 0 0.0
.bss 72748 72748 0 0.0
.data 3300 3300 0 0.0
.rodata 85847 85847 0 0.0
.text 577712 577712 0 0.0
pump-controller-app LP_CC2652R7 (read only) 655095 655095 0 0.0
(read/write) 188752 188752 0 0.0
.bss 72860 72860 0 0.0
.data 3264 3264 0 0.0
.rodata 83895 83895 0 0.0
.text 570720 570720 0 0.0
shell LP_CC2652R7 (read only) 641682 641682 0 0.0
(read/write) 154456 154456 0 0.0
.bss 76932 76932 0 0.0
.data 3408 3408 0 0.0
.rodata 81522 81522 0 0.0
.text 559928 559928 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 602078 602078 0 0.0
.app_xip_area 461104 461104 0 0.0
.bss 83912 83912 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 598178 598178 0 0.0
.app_xip_area 457076 457076 0 0.0
.bss 84072 84072 0 0.0
.data 712 712 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 596842 596842 0 0.0
.app_xip_area 456864 456864 0 0.0
.bss 83044 83044 0 0.0
.data 620 620 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 915984 915984 0 0.0
(read/write) 133184 133184 0 0.0
.bss 131088 131088 0 0.0
.data 2096 2096 0 0.0
.text 915976 915976 0 0.0
BRD4161A+rpc (read only) 950196 950196 0 0.0
(read/write) 149876 149876 0 0.0
.bss 147576 147576 0 0.0
.data 2300 2300 0 0.0
.text 950188 950188 0 0.0
BRD4161A+rs911x (read only) 788052 788052 0 0.0
(read/write) 129404 129404 0 0.0
.bss 127308 127308 0 0.0
.data 2096 2096 0 0.0
.text 788044 788044 0 0.0
lock-app BRD4161A+wf200 (read only) 955364 955364 0 0.0
(read/write) 128240 128240 0 0.0
.bss 126172 126172 0 0.0
.data 2068 2068 0 0.0
.text 955356 955356 0 0.0
window-app BRD4161A (read only) 900904 900904 0 0.0
(read/write) 133256 133256 0 0.0
.bss 131160 131160 0 0.0
.data 2092 2092 0 0.0
.text 900896 900896 0 0.0
esp32 all-clusters-app c3devkit (read only) 1005568 1005568 0 0.0
(read/write) 1480234 1480234 0 0.0
.dram0.bss 69144 69144 0 0.0
.dram0.data 14656 14656 0 0.0
.flash.rodata 211000 211000 0 0.0
.flash.text 1005568 1005568 0 0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1060719 1060719 0 0.0
(read/write) 482432 482432 0 0.0
.dram0.bss 74664 74664 0 0.0
.dram0.data 34208 34208 0 0.0
.flash.rodata 241564 241564 0 0.0
.flash.text 1055335 1055335 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 657944 657944 0 0.0
.bss 69760 69760 0 0.0
.data 2016 2016 0 0.0
.text 580368 580368 0 0.0
lock k32w061+release (read/write) 716960 716960 0 0.0
.bss 70184 70184 0 0.0
.data 1984 1984 0 0.0
.text 638992 638992 0 0.0
linux all-clusters-app debug (read only) 2767985 2767985 0 0.0
(read/write) 178272 178272 0 0.0
.bss 86240 86240 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 83848 83848 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1016 1016 0 0.0
.rodata 244797 244797 0 0.0
.text 2349234 2349234 0 0.0
all-clusters-minimal-app debug (read only) 2645105 2645105 0 0.0
(read/write) 170304 170304 0 0.0
.bss 85504 85504 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 76728 76728 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1016 1016 0 0.0
.rodata 246717 246717 0 0.0
.text 2225826 2225826 0 0.0
bridge-app debug+rpc (read only) 2030641 2030641 0 0.0
(read/write) 147928 147928 0 0.0
.bss 72896 72896 0 0.0
.data 3936 3936 0 0.0
.data.rel.ro 65528 65528 0 0.0
.dynamic 592 592 0 0.0
.got 4272 4272 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 169824 169824 0 0.0
.text 1704274 1704274 0 0.0
chip-tool debug (read only) 9604989 9604989 0 0.0
(read/write) 596976 596976 0 0.0
.bss 23968 23968 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 565600 565600 0 0.0
.dynamic 624 624 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 495805 495805 0 0.0
.text 7729669 7729669 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9358940 9358940 0 0.0
(read/write) 662865 662865 0 0.0
.bss 42257 42257 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 600808 600808 0 0.0
.dynamic 528 528 0 0.0
.got 14816 14816 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 459452 459452 0 0.0
.text 7385348 7385348 0 0.0
lighting-app debug+rpc (read only) 2320777 2320777 0 0.0
(read/write) 153568 153568 0 0.0
.bss 74752 74752 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 71016 71016 0 0.0
.dynamic 608 608 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 188744 188744 0 0.0
.text 1966258 1966258 0 0.0
lock-app debug (read only) 2259441 2259441 0 0.0
(read/write) 148664 148664 0 0.0
.bss 73440 73440 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 67944 67944 0 0.0
.dynamic 592 592 0 0.0
.got 4336 4336 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 201832 201832 0 0.0
.text 1897266 1897266 0 0.0
ota-provider-app debug (read only) 2066625 2066625 0 0.0
(read/write) 141584 141584 0 0.0
.bss 73024 73024 0 0.0
.data 1768 1768 0 0.0
.data.rel.ro 61000 61000 0 0.0
.dynamic 608 608 0 0.0
.got 4504 4504 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 181240 181240 0 0.0
.text 1726290 1726290 0 0.0
ota-requestor-app debug (read only) 2094449 2094449 0 0.0
(read/write) 144424 144424 0 0.0
.bss 73728 73728 0 0.0
.data 1960 1960 0 0.0
.data.rel.ro 63096 63096 0 0.0
.dynamic 592 592 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 177152 177152 0 0.0
.text 1756738 1756738 0 0.0
shell debug (read only) 2572969 2572969 0 0.0
(read/write) 201680 201680 0 0.0
.bss 117096 117096 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 77464 77464 0 0.0
.dynamic 608 608 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 224850 224850 0 0.0
.text 2188674 2188674 0 0.0
thermostat-no-ble arm64 (read only) 2367420 2367420 0 0.0
(read/write) 177505 177505 0 0.0
.bss 87921 87921 0 0.0
.data 1528 1528 0 0.0
.data.rel.ro 80264 80264 0 0.0
.dynamic 528 528 0 0.0
.got 4792 4792 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 148828 148828 0 0.0
.text 1988896 1988896 0 0.0
tv-app debug (read only) 2877721 2877721 0 0.0
(read/write) 280208 280208 0 0.0
.bss 191048 191048 0 0.0
.data 4672 4672 0 0.0
.data.rel.ro 78224 78224 0 0.0
.dynamic 592 592 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 223104 223104 0 0.0
.text 2471986 2471986 0 0.0
tv-casting-app debug (read only) 5327681 5327681 0 0.0
(read/write) 222672 222672 0 0.0
.bss 78632 78632 0 0.0
.data 2400 2400 0 0.0
.data.rel.ro 135432 135432 0 0.0
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 337504 337504 0 0.0
.text 4638962 4638962 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2425752 2425752 0 0.0
.bss 202620 202620 0 0.0
.data 5872 5872 0 0.0
.text 1388396 1388396 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1188179 1188179 0 0.0
bss 141277 141277 0 0.0
rodata 153036 153036 0 0.0
text 814984 814984 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1136943 1136943 0 0.0
bss 140506 140506 0 0.0
rodata 129600 129600 0 0.0
text 788024 788024 0 0.0
p6 all-clusters-app default (read/write) 2542192 2542192 0 0.0
.bss 137104 137104 0 0.0
.data 2808 2808 0 0.0
.text 1500456 1500456 0 0.0
all-clusters-minimal-app default (read/write) 2488160 2488160 0 0.0
.bss 136328 136328 0 0.0
.data 2744 2744 0 0.0
.text 1446424 1446424 0 0.0
light-app default (read/write) 2422304 2422304 0 0.0
.bss 129432 129432 0 0.0
.data 2600 2600 0 0.0
.text 1380568 1380568 0 0.0
lock-app default (read/write) 2440344 2440344 0 0.0
.bss 129248 129248 0 0.0
.data 2568 2568 0 0.0
.text 1398608 1398608 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 780852 780852 0 0.0
bss 70564 70564 0 0.0
noinit 40416 40416 0 0.0
text 552246 552246 0 0.0
lighting-app tlsr9518adk80d (read/write) 800888 800888 0 0.0
bss 70824 70824 0 0.0
noinit 40416 40416 0 0.0
text 568988 568988 0 0.0

@woody-apple woody-apple merged commit d912545 into project-chip:master Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
fast track review - pending scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andy31415 @tcarmelveilleux @woody-apple